Fix 11 clang-tidy checks #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good to me |
bcaddy
force-pushed
the
dev-hackday-4-28
branch
4 times, most recently
from
9349186
to
50415a7
Compare
evaneschneider
approved these changes
Jun 21, 2023
| @@ -151,7 +151,7 @@ int Grid3D::Check_Custom_Boundary(int *flags, struct parameters P) | |||
| } | |||
|
|
|||
| for (int i = 0; i < 6; i++) { | |||
| if (!((flags[i] >= 0) && (flags[i] <= 5))) { | |||
| if (flags[i] < 1 or flags[i] > 5) { | |||
There was a problem hiding this comment.
Do you know if these "or" and "not" statements are portable for other compilers?
There was a problem hiding this comment.
They've been part of the C++ standard since C++98 so any standard compliant compiler will support them; see section 2.5 of the C++98 Standard.
MSVC is historically non-compliant with whatever standards they decide they don't like and so some versions from the mid 2010's and earlier don't support these alternative tokens directly but they can be enabled by either setting the right compiler flags or including the C compliance header.
Fixed and enable modernize-use-auto and its aliad hicpp-use-auto. Removed unsafe alias to a DeviceVector pointer in io.cpp
Also, it's alias cert-dcl59-cpp
This check provides minimal benefit to us and flags every single gtest TEST macro as failing so I've disabled it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang-Tidy Checks
Fixed and enabled the following
clang-tidyChecksDisabled cert-err58-cpp. It provides minimal benifit to us and flags every single gtest
TESTmacro as failing.Other